Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ’ Spell Check All .md Files Related to Flutter πŸ’™ #61564

Merged
merged 62 commits into from Jul 23, 2020

Conversation

@YazeedAlKhalaf
Copy link
Contributor

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 15, 2020

Description

I have made spell correction for all .md files related and made Flutter. It is now more Solid. ALL grammar mistakes have been fixed πŸ›. Although might some see it silly but I think it is one of the most important things to do from time to time.

Related Issues

This is voluntary. So no issues are related to this. I did it because I feel it is important.

Tests

This PR doesn't require a new test since it just changes .md files. Nothing else

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///). (Not Relevant to what I did)
  • All existing and new tests are passing. (Yes, I changed no real Flutter Code, just .md files)
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
@YazeedAlKhalaf
Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 15, 2020

@christopherfujino Great!
I have made the changes except one, needs your answer.

No problem take your time

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jul 16, 2020

@christopherfujino Great!
I have made the changes except one, needs your answer.

Sorry, which is the change you had a question on? I can't see it in the UI.

@YazeedAlKhalaf
Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 16, 2020

dev/integration_tests/gradle_deprecated_settings/README.md

This one @christopherfujino

@YazeedAlKhalaf
Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 16, 2020

Made All changes requested 😊
@christopherfujino

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Everything here LGTM (looks good to me)! Thanks again for all of your work here and sticking with my code review, this is an awesome change. Hope to see you around here again!

@YazeedAlKhalaf
Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 17, 2020

Thanks a lot @christopherfujino πŸ˜ŠπŸ™

Me too

@YazeedAlKhalaf
Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 18, 2020

Why is flutter-build failing?
@christopherfujino

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jul 20, 2020

Why is flutter-build failing?
@christopherfujino

@YazeedAlKhalaf "Flutter build" means that the master branch of flutter is failing testing (this is unrelated to your change). If you want to see the exact reason, you can check our build dashboard: https://flutter-dashboard.appspot.com/#/build. I added the "waiting for tree to go green" label to your PR, which will usually signal a bot to merge the PR once the build dashboard is green. However, it looks like someone else's change caused a merge conflict on your PR (to the file dev/benchmarks/macrobenchmarks/README.md). This means that GitHub isn't sure how to cleanly merge your change with the one someone else already made, and manual intervention is needed. Usually for source code changes, I want to fix this in my text editor, so I will use git and merge upstream master into my feature branch, resolve the conflict in my editor, and then push the resolved version back up. However, since this is a documentation merge conflict, it's probably safe to use the web editor. If you see the "Resolve conflicts" button in GitHub, you can use that to resolve. Let me know if you need any other help!

@YazeedAlKhalaf
Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 20, 2020

Okay, thanks @christopherfujino

I have made the changes

@@ -4,6 +4,33 @@ Performance benchmarks use either flutter drive or the web benchmark harness.

## Mobile benchmarks

### Cull opacity benchmark
Copy link
Contributor

@christopherfujino christopherfujino Jul 20, 2020

Your PR here is adding this text which I don't see on master, maybe this got deleted in a recent change and when merging back in master you accidentally restored it?

Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf Jul 21, 2020

I guess but what I didi isn’t fetch all new things and see what was changed so I changed nothing but I will make sure

Copy link
Contributor

@christopherfujino christopherfujino Jul 21, 2020

When there's a merge conflict you have to manually look through all the changes and decide which makes sense to keep. This change removed the this README text, so with your merge conflict you need to also remove it.

Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot Mar 2, 2021

@christopherfujino You merged it like this, right?

@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot commented Jul 20, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite hostonly_devicelab_tests-3_last-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jul 20, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite hostonly_devicelab_tests-3_last-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

This looks like a timeout (not related to this change), I re-ran it.

@jmagman jmagman merged commit d41b1fb into flutter:master Jul 23, 2020
60 checks passed
@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jul 23, 2020

This is a great change, thank you so much @YazeedAlKhalaf !

@YazeedAlKhalaf
Copy link
Contributor Author

@YazeedAlKhalaf YazeedAlKhalaf commented Jul 23, 2020

This is a great change, thank you so much @YazeedAlKhalaf !

@jonahwilliams You’re welcome πŸš€

Pragya007 added a commit to Pragya007/flutter that referenced this issue Aug 11, 2020
* πŸ› Fix Spelling Issues in Main README.md

* πŸ› Fix spelling issues in dev README.md

* πŸ› Fix spelling issues in complex_layout README.md

* πŸ› Fix spelling issues in macrobenchmarks README.md

* πŸ› Fix spelling issues in platform_views_layout README.md

* πŸ› Fix spelling issues in test_Apps/stocks README.md

* πŸ› Fix spelling issues in bots README.md

* βœ’ Spell Check dev/ci README.md

* βœ’ Spell Check dev/ci/docker_linux README.md

* βœ’ Spell Check dev/devicelab README.md

* βœ’ Spell Check dev/docs README.md

* βœ’ Spell Check dev/snippets README.md

* βœ’ Spell Check dev/snippets/config/templates README.md

* βœ’ Spell Check dev/tools/gen_keycodes README.md

* βœ’ Spell Check dev/tools/vitool README.md

* βœ’ Spell Check examples/catalog README.md

* βœ’ Spell Check examples/flutter_view README.md

* βœ’ Spell Check examples/image_list README.md

* βœ’ Spell Check examples/layers README.md

* βœ’ Spell Check examples/platform_channel README.md

* βœ’ Spell Check examples/platform_channel_swift README.md

* βœ’ Spell Check examples/platform_view README.md

* βœ’ Spell Check packages/_flutter_web_build_script README.md

* βœ’ Spell Check packages/flutter_localizations README.md

* βœ’ Spell Check packages/flutter_tools README.md

* βœ’ Spell Check CODE_OF_CONDUCT.md

* βœ’ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md

* βœ’ Spell Check dev/integration_test/android_views README.md

* βœ’ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md

* βœ’ Spell Check dev/integration_tests/flutter_gallery README.md

* βœ’ Spell Check dev/integration_tests/gradle_deprecated_settings README.md

* βœ’ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md

* βœ’ Spell Check dev/integration_tests/ios_host_app README.md

* βœ’ Spell Check dev/integration_tests/ios_platform_view_tests README.md

* βœ’ Spell Check dev/automated_tests/flutter_test README.md

* βœ’ Spell Check .github/PULL_REQUEST_TEMPLATE.md

* βœ’ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/BUG.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/feature_request.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/performance_others.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md

* βœ’ Spell Check packages/flutter_tools/doc/daemon.md

* βœ’ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md

* βœ’ Minimize line to 80 columns

* βœ’ Minimize line to 80 columns

* βœ’ Fix Typo

* βœ’ Chnaged numbers to 1 for testing purposes

* βœ’ Changed numbers to 1 for testing purposes

* ❌ Remove 'a' which is a typo

* βœ’ Change a sentence to be better

* βœ’ Remove 'a' which is a typo

* βœ’ Fix small issue

* βœ’ Fix small typo

* βœ’ Fix some typos

* ❌ Remove trailing space

* ❌ Remove trailing space

* πŸ› Fix small typo

* βœ’ Fix Typo

* πŸ› Fix small bug
mingwandroid added a commit to mingwandroid/flutter that referenced this issue Sep 6, 2020
* πŸ› Fix Spelling Issues in Main README.md

* πŸ› Fix spelling issues in dev README.md

* πŸ› Fix spelling issues in complex_layout README.md

* πŸ› Fix spelling issues in macrobenchmarks README.md

* πŸ› Fix spelling issues in platform_views_layout README.md

* πŸ› Fix spelling issues in test_Apps/stocks README.md

* πŸ› Fix spelling issues in bots README.md

* βœ’ Spell Check dev/ci README.md

* βœ’ Spell Check dev/ci/docker_linux README.md

* βœ’ Spell Check dev/devicelab README.md

* βœ’ Spell Check dev/docs README.md

* βœ’ Spell Check dev/snippets README.md

* βœ’ Spell Check dev/snippets/config/templates README.md

* βœ’ Spell Check dev/tools/gen_keycodes README.md

* βœ’ Spell Check dev/tools/vitool README.md

* βœ’ Spell Check examples/catalog README.md

* βœ’ Spell Check examples/flutter_view README.md

* βœ’ Spell Check examples/image_list README.md

* βœ’ Spell Check examples/layers README.md

* βœ’ Spell Check examples/platform_channel README.md

* βœ’ Spell Check examples/platform_channel_swift README.md

* βœ’ Spell Check examples/platform_view README.md

* βœ’ Spell Check packages/_flutter_web_build_script README.md

* βœ’ Spell Check packages/flutter_localizations README.md

* βœ’ Spell Check packages/flutter_tools README.md

* βœ’ Spell Check CODE_OF_CONDUCT.md

* βœ’ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md

* βœ’ Spell Check dev/integration_test/android_views README.md

* βœ’ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md

* βœ’ Spell Check dev/integration_tests/flutter_gallery README.md

* βœ’ Spell Check dev/integration_tests/gradle_deprecated_settings README.md

* βœ’ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md

* βœ’ Spell Check dev/integration_tests/ios_host_app README.md

* βœ’ Spell Check dev/integration_tests/ios_platform_view_tests README.md

* βœ’ Spell Check dev/automated_tests/flutter_test README.md

* βœ’ Spell Check .github/PULL_REQUEST_TEMPLATE.md

* βœ’ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/BUG.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/feature_request.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/performance_others.md

* βœ’ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md

* βœ’ Spell Check packages/flutter_tools/doc/daemon.md

* βœ’ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md

* βœ’ Minimize line to 80 columns

* βœ’ Minimize line to 80 columns

* βœ’ Fix Typo

* βœ’ Chnaged numbers to 1 for testing purposes

* βœ’ Changed numbers to 1 for testing purposes

* ❌ Remove 'a' which is a typo

* βœ’ Change a sentence to be better

* βœ’ Remove 'a' which is a typo

* βœ’ Fix small issue

* βœ’ Fix small typo

* βœ’ Fix some typos

* ❌ Remove trailing space

* ❌ Remove trailing space

* πŸ› Fix small typo

* βœ’ Fix Typo

* πŸ› Fix small bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants