Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ephemeral iOS directory to put future generated files #76830

Merged
merged 2 commits into from Feb 26, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 25, 2021

Future prevention of #39491 on iOS. There's nothing currently generated in this ephemeral directory, but I'm about to put out a PR that will generate a few files to this location.

  • Rename iOS module directory property ephemeralDirectory -> ephemeralModuleDirectory
  • Create a project property for Flutter/ephemeral directory.
  • Remove the ephemeralDirectory on flutter clean
  • Add to .gitignore

This doesn't actually move any existing generated files to this location--that can be done in individual follow-up PRs as needed.

@@ -18,6 +18,7 @@ Flutter/App.framework
Flutter/Flutter.framework
Flutter/Flutter.podspec
Flutter/Generated.xcconfig
Flutter/ephemeral/
Copy link
Member Author

@jmagman jmagman Feb 25, 2021

\cc @RedBrogdon Sorry here's another directory to add to all the iOS sample .gitignores. But new ones should be rare in the future with this PR.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

LGTM

@jmagman
Copy link
Member Author

@jmagman jmagman commented Feb 25, 2021

Sorry here's another directory to add to all the iOS sample .gitignores. But new ones should be rare in the future with this PR.

Oh that reminds me, better do the same for the examples/integration_tests in this repo...

@@ -92,6 +92,7 @@ unlinked_spec.ds
**/ios/Flutter/Flutter.framework
**/ios/Flutter/Flutter.podspec
**/ios/Flutter/Generated.xcconfig
**/ios/Flutter/ephemeral
Copy link
Member Author

@jmagman jmagman Feb 25, 2021

The other non-template .gitignores aren't necessary on top of this one, but let's be consistent.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Nice, LGTM!

Apologies for the naming collision; I didn't realize there was already something called "the ephemeral directory" when I made this concept for desktop, and by the time I realized it would have been a giant pain to change.

@jmagman
Copy link
Member Author

@jmagman jmagman commented Feb 26, 2021

Apologies for the naming collision

Naming is hard. "modules" also references several concepts. 😄

@fluttergithubbot fluttergithubbot merged commit d099ae6 into flutter:master Feb 26, 2021
76 checks passed
@jmagman jmagman deleted the ephemeral branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants